Skip to content

fix: include fabricspark in delta file_format config for integration tests#967

Merged
haritamar merged 1 commit intomasterfrom
devin/ELE-5296-1773324915
Mar 12, 2026
Merged

fix: include fabricspark in delta file_format config for integration tests#967
haritamar merged 1 commit intomasterfrom
devin/ELE-5296-1773324915

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Mar 12, 2026 •
edited by coderabbitai Bot
Loading

fix: include fabricspark in delta file_format config for integration tests

Summary

The integration tests dbt_project.yml sets file_format: delta only when target.type == 'spark'. Since dbt-fabricspark also uses Delta Lake (Fabric Lakehouse), it needs the same config. This was missed in the ELE-5295 fabricspark adapter PR (#964).

Both occurrences (under elementary_tests and elementary model configs) are updated from target.type == 'spark' to target.type in ['spark', 'fabricspark'].

Review & Testing Checklist for Human

  • Confirm fabricspark is the correct target.type string used by dbt-fabricspark (consistent with the macros added in feat: add dbt-fabricspark adapter support (ELE-5295) #964)
  • If a Fabric Spark environment is available, run the integration tests against it to verify models materialize correctly with the delta file format

Notes

Companion fix to elementary CLI PR #2142 (merged), which made the same change in elementary/monitor/dbt_project/dbt_project.yml.

Link to Devin session: https://app.devin.ai/sessions/4eb7943788c44f04ab05ace61f50d05b
Requested by: @haritamar

Summary by CodeRabbit

  • New Features
    • Extended dbt project configuration to support Fabric Spark target type in addition to Spark, enabling delta file format compatibility across both Spark and Fabric Spark deployment environments for data models.

@devin-ai-integration @haritamar
fix: include fabricspark in delta file_format config for integration …
9c94763 
…tests

The integration_tests dbt_project.yml only set file_format=delta for
target.type == 'spark'. Fabricspark also uses Delta Lake (Fabric
Lakehouse), so it needs the same config.

Relates to ELE-5296

Co-Authored-By: Itamar Hartstein <haritamar@gmail.com>
@linear
Copy link
Copy Markdown

linear Bot commented Mar 12, 2026

ELE-5296 Add dbt-fabricspark support to elementary CLI

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

devin-ai-integration Bot commented Mar 12, 2026

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 12, 2026

👋 @devin-ai-integration[bot]
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 12, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 37111e63-3b16-43ec-8213-f4196be82b19

📥 Commits

Reviewing files that changed from the base of the PR and between 5fafd8d and 9c94763.

📒 Files selected for processing (1)
  • integration_tests/dbt_project/dbt_project.yml
📝 Walkthrough

Walkthrough

Updated dbt project configuration in dbt_project.yml to expand the delta file_format condition, now targeting both 'spark' and 'fabricspark' target types instead of spark alone. Changes applied to tmp and elementary model blocks.

Changes

Cohort / File(s) Summary
DBT Project Configuration
integration_tests/dbt_project/dbt_project.yml		 Expanded delta file_format condition to include both spark and fabricspark target types in conditional template logic for tmp and elementary models.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hopped through dbt's neat array,
Found spark was lonely in its special way,
So fabricspark joined the delta dance,
Two targets now share the configuration's chance! 🐰✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: adding fabricspark support to the delta file_format configuration in integration tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devin/ELE-5296-1773324915
📝 Coding Plan for PR comments
  • Generate coding plan

Comment @coderabbitai help to get the list of available commands and usage tips.

@haritamar haritamar merged commit 11c1374 into master Mar 12, 2026
27 of 28 checks passed
@haritamar haritamar deleted the devin/ELE-5296-1773324915 branch March 12, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haritamar haritamar haritamar approved these changes

Assignees

@haritamar haritamar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@haritamar